[TIMOB-767] Implemented 'swipe' event for Android. #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -938,6 +939,23 @@ public boolean onSingleTapConfirmed(MotionEvent e) { | |||
| return false; | |||
| } | |||
| @Override | |||
| public boolean onFling(MotionEvent e1, MotionEvent e2, float velocityX, float velocityY) | |||
There was a problem hiding this comment.
Indentation looks to be off here from the rest of the code block.
|
Functional test looked good. Just one code review comment above. If you could convert |
|
@joshthecoder spaces are changed to tabs now |
|
Code reviewed. Accepted |
joshthecoder
added a commit
that referenced
this pull request
Apr 4, 2012
[TIMOB-767] Implemented 'swipe' event for Android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and test case found here: https://jira.appcelerator.org/browse/TIMOB-767
Android supports both horizontal and vertical swipes. The docs have been updated to reflect this.