Fix https://jira.appcelerator.org/browse/TIMOB-6839 #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code review accepted @Shalom The functional test on this looks good (kroll-apt.jar and kroll-common.jar are correctly added), but I noticed that TiStudio doesn't recognize the default JRE system container, so I still see build errors on the Android module project. I tested with 2.0.0.201203161928 |
|
We will add a TiStudio check for the existence of the JDT before allowing creating a module project. Thanks! |
joshthecoder
added a commit
that referenced
this pull request
Mar 27, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple fix to add missing Jar files into the .classpath that is generated for the Eclipse project.
Right now, we get Java compilation errors right after creating a new Mobile Module project in Titanium Studio, so this is pretty important.
Thanks!