[TIMOB-4598] Markdown won't be run on ignored files anymore. #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -157,6 +157,7 @@ def docgen(module_dir, dest_dir): | |||
| return | |||
|
|
|||
| for file in os.listdir(doc_dir): | |||
| if file in ignoreFiles: continue; | |||
There was a problem hiding this comment.
Semi-colon shouldn't be needed here. Anyway, would you mine putting the continue on the next line? PEP 8 discourages compound statements, and I tend to agree. It's anal, I know. :) Guido doesn't like them: "Compound statements (multiple statements on the same line) are generally discouraged." http://www.python.org/dev/peps/pep-0008/
|
@billdawson: Done. |
|
You rock! |
|
Accepted. Code review good. Functional: I reproduced original error (the presence .DS_Store gives an error when running ant). With Dawson's change, no error and documentation/ in the packaged ZIP looks good. (I was using the android UrbanAirship module as example.) |
|
code review accepted |
billdawson
added a commit
that referenced
this pull request
Jul 7, 2011
[TIMOB-4598] Markdown won't be run on ignored files anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check to see if the current file should be run through markdown or ignored.
http://jira.appcelerator.org/browse/TIMOB-4598
(Note: this is the Android version of this original ticket: http://jira.appcelerator.org/browse/TIMOB-4554 that has this pull request: #184)