Timob 7799 Removed Flexbox #1885
Conversation
…e into timob-7799
| width = lang.val(this.width,this._defaultWidth), | ||
| height = lang.val(this.height,this._defaultHeight); | ||
| (isDef(this.width) || !widthOverride) && (isWidthSize = (width === UI.INHERIT ? this._getInheritedWidth() : width) === UI.SIZE); | ||
| (isDef(this.width) || !heightOverride) && (isHeightSize = (width === UI.INHERIT ? this._getInheritedWidth() : width) === UI.SIZE); |
There was a problem hiding this comment.
There's an awful lot of widths on this line.
There was a problem hiding this comment.
Good catch on the bug. It slipped my testing somehow.
| return value; | ||
| }, | ||
| value: UI.TEXT_VERTICAL_ALIGNMENT_CENTER | ||
| }, |
|
You missed a textContainerDiv in Label in _setTextShadow() that is breaking drop shadows. |
|
I created a ticket TIMOB-8447 to remove all returns from all property post functions. Could you remove the returns from all post functions from the files touched in this PR? I know there's some in Label. |
|
Done. |
| var text = self._textContainerDomNode.innerHTML; | ||
| return { | ||
| width: self._measureText(text, textContainerDomNode, width).width, | ||
| height: self._measureText(text, textContainerDomNode, width).height |
There was a problem hiding this comment.
This should probably be "height", not "width".
There was a problem hiding this comment.
No it's actually correct. Width (inside the parenthesis) is used to specify a maximum width of the label, i.e. it's used when you want to measure the height of wrapped text.
|
There are still a couple of blockers preventing this PR from being merged. The following are generally issues that weren't issues prior to this PR.
|
|
Code reviewed and tested. Request accepted. |
No description provided.