Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-8373] iOS: TextFields and TextAreas should have a minimum height/width when they are SIZE and text is empty #1933

Merged
merged 3 commits into from Apr 5, 2012

Conversation

mstepanov
Copy link
Contributor

TIMOB-8373
The fix also addresses parity issue with Android where text field/area with SIZE hint adjust in width during typing.

Test case in JIRA comment.
Check regressions with KS Controls/Text Field/Text Area

@vishalduggal
Copy link
Contributor

Will CR + FR

@vishalduggal
Copy link
Contributor

Code Reviewed. REJECTED

The contentHeightForWidth also checks [self hasText] which needs to be removed

@vishalduggal
Copy link
Contributor

Code Reviewed. ACCEPTED

@vishalduggal
Copy link
Contributor

Functional passed. ACCEPTED

vishalduggal added a commit that referenced this pull request Apr 5, 2012
[TIMOB-8373] iOS: TextFields and TextAreas should have a minimum height/width when they are SIZE and text is empty
@vishalduggal vishalduggal merged commit d27fab5 into tidev:master Apr 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants