Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIMOB-8048 properly dispatch messages onto the window associated with a ... #2026

Merged
merged 4 commits into from Apr 18, 2012
Merged

TIMOB-8048 properly dispatch messages onto the window associated with a ... #2026

merged 4 commits into from Apr 18, 2012

Conversation

rusticphilosopher
Copy link
Contributor

@mstepanov
Copy link
Contributor

co-CR approved

@billdawson
Copy link
Contributor

bill will handle FR and second CR

@billdawson
Copy link
Contributor

I was worried the hard ref to the proxy (wrappedViewProxy) might cause a memory leak, so I did a before/after test. Indeed it sticks around after backing out of the app and forcing GC many times (in DDMS). Screenshot from Memory Analyzer Tool: https://skitch.com/bill_dawson/8wypc/memory-analysis-var-folders-5p-hknbdsws2hldr-yvw4xr-9300000gn-t-android3803320772033520997.hprof-eclipse-users-bill-projects-eclipse-workspace

If you override releaseViews and therein nullify wrappedViewProxy, the leak goes away.


TiViewProxy viewProxy = currentTab.getWindow();
if (viewProxy instanceof TiBaseWindowProxy) {
viewProxy = ((TiBaseWindowProxy) viewProxy).getWrappedView();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mention in the comment for getWrappedView below that caller is responsible for null-checking the return value, but it's not done here.

return null;
}
}*/
private TiViewProxy wrappedViewProxy;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this baby gotta go bye bye

@billdawson
Copy link
Contributor

FR/CR ACCEPTED

billdawson added a commit that referenced this pull request Apr 18, 2012
TIMOB-8048 properly dispatch messages onto the window associated with a ...
@billdawson billdawson merged commit b325c76 into tidev:master Apr 18, 2012
@mstepanov
Copy link
Contributor

followup CR APPROVED

@robsjc
Copy link

robsjc commented Apr 25, 2012

FYI – my update for 04.25.12

Sorry for the quick exit. Chris and I got booted out of conf room.

Myself, I'm many layers deep into Drillbit front end…

  • evaluating best fit implementation for command line interface (without making changes to core backend – this intended to be temporary solution)
  • finding that current implementation is very tightly integrated with GUI (GUI objects represent persistent data structures and runtime status)… fortunately command line tests are 'single shot' and are not dependent on overall suite status and other data represented in GUI
  • considering to Implement a command line Class without GUI dependencies… overload existing functions.
  • investigating community (Titan) project that claims Titanium class can be imported into NodeJS thereby enabling another entry point for extended interface

Robert Collazo

QA Automation Engineer

Appcelerator, Inc.

rcollazo@appcelerator.commailto:rcollazo@appcelerator.com

unknown.png

The Next Generation Mobile Platform

http://www.appcelerator.comhttp://www.appcelerator.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants