New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TIMOB-8048 properly dispatch messages onto the window associated with a ... #2026
Conversation
co-CR approved |
bill will handle FR and second CR |
I was worried the hard ref to the proxy ( If you override |
|
||
TiViewProxy viewProxy = currentTab.getWindow(); | ||
if (viewProxy instanceof TiBaseWindowProxy) { | ||
viewProxy = ((TiBaseWindowProxy) viewProxy).getWrappedView(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mention in the comment for getWrappedView
below that caller is responsible for null-checking the return value, but it's not done here.
return null; | ||
} | ||
}*/ | ||
private TiViewProxy wrappedViewProxy; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this baby gotta go bye bye
FR/CR ACCEPTED |
TIMOB-8048 properly dispatch messages onto the window associated with a ...
followup CR APPROVED |
FYI – my update for 04.25.12 Sorry for the quick exit. Chris and I got booted out of conf room. Myself, I'm many layers deep into Drillbit front end…
Robert Collazo QA Automation Engineer Appcelerator, Inc. rcollazo@appcelerator.commailto:rcollazo@appcelerator.com The Next Generation Mobile Platform |
...tab
https://jira.appcelerator.org/browse/TIMOB-8048
Test case in ticket.