[TIMOB-8682] Android: Setting "top" to null causes "bottom" to not be recognized #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring as undefined(null)
| @@ -545,9 +545,10 @@ public static TiDimension toTiDimension(Object value, int valueType) | |||
| { | |||
| if (value instanceof Number) { | |||
| value = value.toString() + TiApplication.getInstance().getDefaultUnit(); | |||
There was a problem hiding this comment.
There should also be a return value for this case.
|
code reviewed and functionally tested. Ran drillbit ui and ui.layout test for sanity check. All passed. Accepted |
ayeung
pushed a commit
that referenced
this pull request
Apr 19, 2012
[TIMOB-8682] Android: Setting "top" to null causes "bottom" to not be recognized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIMOB-8682
Also fixes TIMOB-8742
Test cases in JIRAs. For TIMOB-8682 try both null and undefined.
Also fixes potential ClassCastException when value other than number or string is assigned to a property.