Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-5799] Android: Child element does not respect opacity of parent #2051

Merged
merged 1 commit into from Apr 25, 2012

Conversation

joshthecoder
Copy link
Contributor

See TIMOB-5799 for testing details.
There are two test cases attached.

The first is the original test case attached to the ticket.
When you run this test case w/ this fix you should see image, just a blank white window.

The second test case provides a similar setup, but includes sliders to adjust
the opacity of the parent and child views. Try adjusting the child opacity first. This should
only affect the child view and not change the parent's opacity. Then try adjusting the parent opacity.
You should notice both the parent and child have their opacity changed.

The behavior should be compared to iOS as well to make sure we have parity.

@joshthecoder
Copy link
Contributor Author

Also note this should be tested on both a 3.0+ and 2.2/2.3 device. With 3.0 or later we use the "native" setAlpha()
to apply opacity. On older devices we use a software workaround. Both methods should be tested to verify they work.

@pingwang2011
Copy link
Contributor

code reviewed and functionally tested on both 2.3 and 3.1 devices. Accepted

marshall added a commit that referenced this pull request Apr 25, 2012
[TIMOB-5799] Android: Child element does not respect opacity of parent
@marshall marshall merged commit d12b85a into tidev:master Apr 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants