[TIMOB-7664] iOS: Allow for custom Info.plist values via tiapp.xml #2053
Conversation
|
Will CR+FR |
|
|
||
| plist_props = self.ios['plist'] | ||
| for prop in plist_props: | ||
| self.infoplist_properties[prop] = plist_props[prop] |
There was a problem hiding this comment.
Note that doing this does not replace any existing autogenerated values in the property list, or values from the template, such as CFBundleDevelopmentRegion, CFBundleURLName, or CFBundleURLSchemes (neither of which should be replaced). The following values should be considered "static" (immutable) by the <plist> extension, because they are directly controlled by universal tiapp.xml settings:
- CFBundleURLName
- CFBundleIdentifier
- CFBundleInfoDictionaryVersion
- CFBundlePackageType
- CFBundleVersion
- LSRequiresIPhoneOS
The following should be considered "appended to:"
- CFBundleURLSchemes
The following should be considered "overwrite" (takes precedence over existing deprecated properties):
- Any value not listed as "static" or "append" above
This list is based upon our existing Info.plist template and tiapp.py#generate_infoplist.
|
Code reviewed; please address comments. Our handling of |
| rc.append(node.data) | ||
| return ''.join(rc) | ||
|
|
||
| ignore_keys = ['CFBundleDevelopmentRegion', 'CFBundleDisplayName', 'CFBundleExecutable', 'CFBundleIconFile', |
There was a problem hiding this comment.
We should be able to toggle CFDevelopmentRegion, since it shouldn't be hardcoded as "English". I'm not sure if this is picked up or modified by tiapp.xml at this time, but it could be at a future point where we improve localization support. For now we'll need to allow modding it.
|
Code reviewed; please address comment. This might have to be a temporary change but is necessary until we get better locale support... unless we support it right now and I don't know. |
…n in tiapp.xml, if any
|
Code reviewed, APPROVED. |
|
Functional tested, failed without the Left a comment on the source about how to fix this. |
| 'CFBundleIdentifier', 'CFBundleInfoDictionaryVersion', 'CFBundleName', 'CFBundlePackageType', 'CFBundleSignature', | ||
| 'CFBundleVersion', 'CFBundleShortVersionString', 'LSRequiresIPhoneOS'] | ||
|
|
||
| self.ios['plist'] = {} |
There was a problem hiding this comment.
The problem is if we don't have an <ios> section at all - this doesn't get triggered. One thing that can be done is instead is a has-key check before iterating through the ios plist below.
|
Code reviewed, APPROVED. |
|
Functional tested. Pass. APPROVED. |
[TIMOB-7664] iOS: Allow for custom Info.plist values via tiapp.xml
TIMOB-7664
FT: paste ios section example from JIRA into tiapp.xml. Build/launch in Simulator the app from TiStudio, then open build/iphone/Info.plist file to verify values.
The changes also addresses some Info.plist indentation formatting issues.