[TIMOB-8423] Added support for trace, notice, fatal, and critical. #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| console.trace = 0; // need to undefine trace() since it does something completely different | ||
|
|
||
| for (; i < 9; i++) { |
There was a problem hiding this comment.
Could we do a len variable set to fns.length? I could see us adding/removing one of these in the future and forgetting to update this hard-coded value.
There was a problem hiding this comment.
Trying to save bytes. I highly doubt we'll change these in the foreseeable future.
|
Code reviewed and tested. Request accepted. |
nebrius
added a commit
that referenced
this pull request
Apr 27, 2012
[TIMOB-8423] Added support for trace, notice, fatal, and critical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.