[TIMOB-8725] Handling new window inside a modal window. #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test in any/all orientation related tickets that seems relevant. |
| if([thisWindow modalFlagValue] == YES){ | ||
| isInsideModalWindow = YES; | ||
| NSLog(@"[WARN] Trying to open a new window from within a Modal Window is unsupported."); | ||
|
|
There was a problem hiding this comment.
no need to continue the loop when modal window is found. add break
|
Code reviewed. APPROVED |
mstepanov
pushed a commit
that referenced
this pull request
Apr 30, 2012
[TIMOB-8725] Handling new window inside a modal window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure there are no regressions
*TESTING INSTRUCTIONS.
*TIMOB-8725
TEST FOR REGRESSIONS IN THE FOLLOWING TICKET
*TIMOB-7486 -- The sandwiched case still fails the same way.
*TIMOB-7627
*TIMOB-6551
*TIMOB-6391
*TIMOB-4619
*TIMOB-1634
This is PR throws out a warning when user try's to open a new window from within a model window. and possibly to correct the orientation is some cases(*NOT ALL).