[TIMOB-8668] iOS: OptionDialog has wrong rotation inside Modal Windows #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Talked with Sabil wrt finding the key window. Waiting for fixing commit. |
|
CR approved. Doing PR now. |
|
FR passed. Pushing button. |
WhichKatieDid
added a commit
that referenced
this pull request
May 1, 2012
[TIMOB-8668] iOS: OptionDialog has wrong rotation inside Modal Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like we where not attaching the ActionSheet/OptionDialog to the topmostview in the app and instead where attaching it to the RootviewController's view.
Test Instruction in Jira
Run a pass on KitchenSink also to make sure there is no regressions