TIMOB-8653 Tooling separation: remove support/ #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… keeping enough for titanium_mobile to build itself.
… seems intimately tied to core. Also bring back pre-packaged stuff.
…ources in android modules.
Conflicts: support/android/builder.py support/iphone/builder.py support/mobileweb/compiler.py support/tiapp.py
…th device is rotated
TIMOB-8789: Android: headerView label displaying issues after scrolling ...
[TIMOB-8613] Resize titleControl on rotation
TIMOB-8903: Android: scrollView - does not resize width of content with ...
[TIMOB-8668] iOS: OptionDialog has wrong rotation inside Modal Windows
[TIMOB-8929] Fixed a typo in rect.
[TIMOB-8628]Call UIViewControllerDelegate methods explicitly for 4.x
|
|
||
| // If we measure the child height to be greater than the parent height, use it in subsequent | ||
| // calculations to make sure the children are measured correctly the second time around. | ||
| height = Math.max(child.getMeasuredHeight(), height); |
There was a problem hiding this comment.
Is this code intended to fix another bug? :)
|
False alarms -- looks like github put platform diffs here when they weren't actually changed. Code and functional review accepted |
|
FWIW, ran all of the tests in Bill's ticket, as well as "docgen", and "fastdev" on titanium.py |
marshall
added a commit
that referenced
this pull request
May 2, 2012
TIMOB-8653 Tooling separation: remove support/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This must go hand-in-hand with the titanium_mobile_tooling PR here:
appcelerator-archive/titanium_mobile_tooling#1
Testing Notes