Timob 9098-2_0_X: Password not masked properly #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Functional Failed. Testing on Nexus S Android version 4.0.4. Password mask gets disabled in landscape mode. |
| @@ -430,6 +426,12 @@ public int getInputType() { | |||
| if (passwordMask) { | |||
| tv.setTransformationMethod(PasswordTransformationMethod.getInstance()); | |||
| textTypeAndClass |= InputType.TYPE_TEXT_VARIATION_PASSWORD; | |||
| //turn off text UI in landscape mode in 4.0 b/c Android numeric passwords are not masked correctly in landscape mode. | |||
| if (Build.VERSION.SDK_INT == TiC.API_LEVEL_ICE_CREAM_SANDWICH && (type == KEYBOARD_NUMBERS_PUNCTUATION || | |||
There was a problem hiding this comment.
Use >= and the FR passes on Nexus with Android 4.0.4
There was a problem hiding this comment.
Fix needs to be applied on master as well
|
Code Reviewed. APPROVED |
|
Functional Failed. Testing on Android version 2.3.6. Might just have to disable it across all versions of Android just to be safe and provide a consistent UI behavior. REJECTED |
|
Also failed on Droid 2.2.4 when using soft keyboard in LANDSCAPE MODE |
|
Code reviewed. ACCEPTED |
|
Functional Passed. Tested an Android Device (2.2.4 and 4.0.2). ACCEPTED |
vishalduggal
added a commit
that referenced
this pull request
May 17, 2012
Timob 9098-2_0_X: Password not masked properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-9098
Testing steps in JIRA