[TIMOB-8965] [TIMOB-8966] [TIMOB-8948] Analytics bug fixes and parity #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…analytics event data payload. Fixed session ids. Fixed sequence ids.
|
Under testing, the SDK version does not appear on the first analytics event sent (enroll) on an app's first run (i.e. safari was reset before running). It appears in subsequent runs and appears if safari is not reset prior to running and the app has been run before. Everything else looks good though. |
|
ti.enroll is not suppose to have the sdk version. It should however be in ti.start. |
|
Strange choice, but if it's expected, then everything looks good. Code reviewed and tested. Request accepted. |
nebrius
added a commit
that referenced
this pull request
May 19, 2012
[TIMOB-8965] [TIMOB-8966] [TIMOB-8948] Analytics bug fixes and parity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues:
TIMOB-8965 - Analytics does not have platform information
TIMOB-8966 - Analytics does not have version parameter
TIMOB-8948 - Analytic is not creating a new session id for new sessions
This also fixes: