[TIMOB-9332] Added centerOffset property to TiMapView.m

[joscandreu]

This commit corresponds to this jira ticket: https://jira.appcelerator.org/browse/TIMOB-9332

It enables to use centerOffset property in a Ti.Map.Annotation.

annotation.setCenterOffset({x: 0, y:-25});
//or
Ti.Map.createAnnotation({
centerOffset: {x:0, y:-25}
});

The CLA is signed with e-mail: joscandreu@gmail.com with the name: Jose Carlos Andreu Galan
I'm going to provide a simple test case in the comments of the jira ticket.

[negupta]

Signed CLA is in place.

[WhichKatieDid]

Question: What happens if this centerOffset is changed while the view exists/is already placed? Read: There should be a setter for the centerOffset in question to avoid race conditions where the centerOffset is set after annotation creation. There also needs to be a change to apidoc/Titanium/Map/Annotation.yml to reflect this. Finally, there needs to be parity with Android/Mobile Web, or at least Jiras for such parity. CR: Needs revisions.

[joscandreu]

I tried to set centerOffset twice once the annotation was already shown in the map and everything went fine, but I'm going to check and create that setter, should that be in TiMapAnnotationProxy.m, right?

Do I have to open those tickets in Jira by myself as I did with this one?
I didn't know the apidocs where also in version control. I'll add this property.

[WhichKatieDid]

Correct. TiMapAnnotationProxy.m

I'll handle the JIRA tickets.

[joscandreu]

I added the centerOffset setter in MapAnnotationProxy.m and modified the docs with the description of the property. Are the getters and setters created automatically from the properties in the docs?

[joscandreu]

Any problems with the last commit? It's been 10 days without any response.

[WhichKatieDid]

Apologies for the delay. I should clarify. The way the Apple Mapkit handles annotations is that they are recycled when they go offscreen. So if you have 2 image annotations, and both go offscreen, the view that was associated with annotation A may be instead used for annotation B and vice versa.

1. In the current implementation, the offset is only assigned after the view is created. Not on reuse, not while onscreen. For reuse, the centerOffset should be in the same if statement as annView.image = image; Furthermore, it should always be assigned (The TiUtils CGPoint method defaults to (0,0) on nil) in case the view had an offset from a previous annotation.

2. The getter is automatic, so you don't need to worry about it, but the setter, in order to propagate this change to the view, needs the if statement:
   if (current!=leftview)
   {
   [self setNeedsRefreshingWithSelection:YES];
   }

[joscandreu]

Thanks for the comments. I'll update ASAP with these changes.

[negupta]

@joseitinerarium - Please let us know if you plan to address these comments.

[joscandreu]

Yes I plan to address the comments but I've been unable to review and code the missing points.

[negupta]

Closing this pull request due to lack of response. Please open a new pull request if you decide to address and code the comments.