[TIMOB-9314] Support for mixed JS and Obj-C modules. #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes which prevented building for iOS simulator on machines with spotlight disabled.
|
There appears to be an issue with pure JS (non-compiled) modules. Please hold while I fix it. |
|
Fixed issue, review can proceed. The bug that should be examined and resolved is 9316; 9314 is the umbrella bug. |
|
Code reviewed. APPROVED |
|
FT PASSED |
mstepanov
pushed a commit
that referenced
this pull request
Jun 8, 2012
[TIMOB-9314] Support for mixed JS and Obj-C modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows modules which are built with both a JS file and Objective-C code to coexist. Both are exported to the user.
This also includes fixes which prevented building for iOS simulator on machines with spotlight disabled.