timob-9432: Android: Views - Buttons "Add", "Change" and "Jump" are missing from a toolbar #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code reviewed. Looks good |
|
Functional failed. If I press the left or right arrow immediately after the screen shows up the emulator keeps throwing an array out of bounds exception. Although I think the bug is unrelated to this PR it would be nice if the bug could be investigated. REJECTED |
|
Accepting and merging this PR since the crash is being handled by another ticket TIMOB-9474 |
vishalduggal
added a commit
that referenced
this pull request
Jun 8, 2012
timob-9432: Android: Views - Buttons "Add", "Change" and "Jump" are missing from a toolbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-9432
Test steps in JIRA.