TIMOB-9336 Android: If java location for Windows is determined by builder.py, go ... #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…go ahead and set JAVA_HOME if it's not set. That helps titanium_prep.win32.exe down the road in the packaging process. Also quit an application build if titanium_prep fails.
|
Code reviewed. APPROVED |
|
FT passed on MacOS. |
|
FT PASSED on WinXP/Win7/Linux32/Linux64 |
mstepanov
pushed a commit
that referenced
this pull request
Jun 11, 2012
TIMOB-9336 Android: If java location for Windows is determined by builder.py, go ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ahead and set JAVA_HOME if it's not set.
That helps titanium_prep.win32.exe down the road in the packaging process.
Max should test this because he is familiar with titanium_prep. (@mstepanov)
See Testing Notes
Along with this is: https://github.com/appcelerator/titanium_prep/pull/6