TIMOB-9468 Update the 2dmatrix test to account for the fact that scale a... #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and rotation transforms now have origin in the center of the animated view (as opposed to upper-left), for parity with iOS (this was done in previous commits.) The delta of 25 is explicable in the sense that with the origin now at the center, the origin is calculated as 0.5 x width, and the test is for 50px width (0.5 x 50 == 25).
|
Code reviewed and functionally tested. Ran drillbit on v8 and rhino. Request Accepted |
ayeung
pushed a commit
that referenced
this pull request
Jun 12, 2012
TIMOB-9468 Update the 2dmatrix test to account for the fact that scale a...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...nd rotation transforms now have origin in the center of the animated view (as opposed to upper-left), for parity with iOS (this was done in previous commits.)
https://jira.appcelerator.org/browse/TIMOB-9468
@ayeung is a probably a good candidate to review this since he's now familiar with it after reviewing the other PRs that led to this change.
It's a very quick test: run the ui.2dmatrix drillbit test.