[TIMOB-9434] [TIMOB-8672] Fix handling of trueHeading in compass events #2373
Conversation
| if (provider != null) { | ||
| Location location = tiLocation.locationManager.getLastKnownLocation(provider); | ||
| if (location != null) { | ||
| if (geomagneticField == null || location.getTime() > geomagneticFieldLocation.getTime()) { |
There was a problem hiding this comment.
No null checking for geomagneticFieldLocation
There was a problem hiding this comment.
There is a concern here I think regarding the integrity of the location data. At which point is the location data provided so old that it is worse to use it in order to report data versus simply reporting that we are unable to report data? I would argue that it is better to say we are unable to report data rather than use a location fix that may be days old.
There was a problem hiding this comment.
Good point. I think somewhere between 1 hour and 8 hours would be a good threshold for freshness. In that time you could hop a plane or drive far enough to significantly alter the declination. And if the app can't get a fix once an hour, either the fix is unavailable, or they aren't trying very hard.
There was a problem hiding this comment.
I don't see why we shouldn't have a much tighter threshold for freshness - say less than 10 minutes. If the location is older than that, we could register one for the purpose of getting a fresh fix.
There was a problem hiding this comment.
Sorry, missed this comment on my earlier update. I didn't know how expensive it was to create a new GeomagneticField, so I didn't want to overdo it. Once every 10 minutes is good by me. Around here, the declination correction only changes about a 1/10th of a degree for each 60 miles. It changes a lot faster inside the Arctic circle, but IMHO, anyone who uses an Android app for navigating inside the Arctic circle is asking for trouble.
When you say, "We could register one..." Do you mean adding a location request in TiCompass? I think you might need to hold my hand for that one ;-).
|
Updated the threshold to 10 minutes. If nothing else, it should make testing less of a pain. Will try to catch you tomorrow to talk about whether I need to kick off a location request. |
|
Spoke with Arthur and he is going to update the logging and handling of stale locations. |
|
Code reviewed and functional test passed. Accepted |
[TIMOB-9434] [TIMOB-8672] Fix handling of trueHeading in compass events
Note: This is not a doc PR, it's a code PR so I don't have to add some ugly workarounds in the doc. Should probably be reviewed by Opie as the resident Android Geo expert.
Two related fixes for compass on Android. I apologize for including two bugs, but they're related and the same test code serves them both. Test code is in TIMOB-9434.
https://jira.appcelerator.org/browse/TIMOB-9434
https://jira.appcelerator.org/browse/TIMOB-8672