[TIMOB-9116] multiple layout issues #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 12, 2012 11:00
…lling minimumParentHeightForSize since it does that too.
…ing minimumParentHeightForSize since it does that too.
| } | ||
| bounds.size.width = desiredWidth + offset; | ||
| bounds.size.width = desiredWidth + offsetH; |
There was a problem hiding this comment.
Double addition. desiredWidth already has offsetH added.
|
Two minor points. Otherwise code look good. |
|
Code Reviewed. ACCEPTED |
|
Functional Passed. Ran Drillbit ui layout, light KS and test case in TIMOB-9116. ACCEPTED |
vishalduggal
added a commit
that referenced
this pull request
Jun 14, 2012
[TIMOB-9116] multiple layout issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIMOB-9116
CR: better to do it per commit.
FR: Test cases are in JIRA. + KS layout tests + drillbit layout tests.