[TIMOB-4620] Don't blindly forward hitTest to touch delegate #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontain interactive elements is a bad idea.
|
we ran this on ipad2, iphone4 verizon, iphone4 att, ipad1 (4.3). we found a new cosmetic issue, logged as http://jira.appcelerator.org/browse/TIMOB-4753 |
|
TIMOB-4753 is completely unrelated to this pull request. It appears regardless of whether or not this fix is checked in, which only has to do with interactivity of table elements. |
|
Code reviewed. Approved. |
rseagraves
added a commit
that referenced
this pull request
Jul 26, 2011
[TIMOB-4620] Don't blindly forward hitTest to touch delegate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like it's a bad idea to forward messages directly to the touch delegate in situations like this:
touchDelegate ---> view ---> interactive elementThis fix comments out (NOT removes) the block that does this, because it may introduce unexpected regressions. I ran the full suite of KS tableview tests when checking the bugfix to ensure none occurred, but some may still come up. It is strongly recommended that reviewers ALSO run at least those tests in KS which depend on interactivity of elements contained within rows.