[TIMOB-8740] New features and bug fixes in require() #2382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt. Running into issues with modules being executed simutaneously during dependency resolution.
…ded support for connection timeouts. Moved has() out of loader.
| @@ -67,6 +63,14 @@ | |||
| // map of package names to package resource definitions | |||
| packages = {}, | |||
|
|
|||
| // module states | |||
| // default state unloaded = 0 | |||
| requested = 1, // module is being downloaded | |||
There was a problem hiding this comment.
Since these are constants, they should be UPPER_CASE style.
|
Code reviewed and tested. Request accepted. |
nebrius
added a commit
that referenced
this pull request
Jun 13, 2012
[TIMOB-8740] New features and bug fixes in require()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[TIMOB-8740] require() isn't properly loading async resources
[TIMOB-9318] require() doesn't work within Ti+ modules
[TIMOB-9131] Apps do not load if the Google Maps server are inaccessible