TIMOB-9315 When loading external modules, also load any CommonJS module ... #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le they may be carrying.
|
Code reviewed and functional test passed against V8 and Rhino. Accepted |
rusticphilosopher
pushed a commit
that referenced
this pull request
Jun 15, 2012
TIMOB-9315 When loading external modules, also load any CommonJS module ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...they may be carrying.
The test is in the umbrella item:
https://jira.appcelerator.org/browse/TIMOB-9314
So if everything works out and you merge this, you should resolve both
https://jira.appcelerator.org/browse/TIMOB-9314
and
https://jira.appcelerator.org/browse/TIMOB-9315