Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timob 9517: Added auto link support for TextField and TextArea. #2474

Merged
merged 2 commits into from Jun 29, 2012

Conversation

hieupham007
Copy link
Contributor

@negupta
Copy link
Contributor

negupta commented Jun 27, 2012

Do iOS and Mobile Web platforms support auto link in TextField and TextArea? We need to make sure that this feature is available on all platforms before merging this PR.

@hieupham007
Copy link
Contributor Author

iOS supports TextArea but not TextField, and I don't think MobileWeb has support for autoLink at all.

@negupta
Copy link
Contributor

negupta commented Jun 27, 2012

We cannot review and merge this PR until there is a parity across all platforms. Please refer to my email yesterday about sending these changes to the architecture council mailing list.

@nebrius
Copy link
Contributor

nebrius commented Jun 27, 2012

Mobile Web doesn't support this behavior today. It will be non-trivial for us to support this behavior too because input fields do not support embedding tags in them (i.e. you can't embed a link inside an input field).

EDIT: I should clarify that it is not impossible to do, but we would have to roll our own rich text editor or use a pre-existing one. This would require a complete rewrite of textfield and textarea.

@hieupham007
Copy link
Contributor Author

I've brought this up in the architecture meeting today, and given the current state of the platforms, I think it's a good idea to process this PR and document the changes. It is not trivial for Mobile Web to implement this feature and iOS doesn't support autolink for TextField.

Documentation of the changes should be in this PR also.

@WhichKatieDid
Copy link
Contributor

iOS does not natively support autolink in TextField or label. iOS already has TextArea autolink support, albeit with different constants. The architectural meeting did touch on this, because there's two issues. The first is to use prevailing Android precedent and have the TextArea match the behavior they have with label.

The second, because it's a behavior change, is to deprecate the constants in iOS and Android namespaces, and use new constant names in the UI namespace. Part of this change is to allow the autolink property to accept an array of constants as well. But this behavior change is for 2.2, not a parity bugfix.

@negupta
Copy link
Contributor

negupta commented Jun 28, 2012

Lets process this PR and file a ticket for the behavior change as Blain outlined.

@ayeung
Copy link
Contributor

ayeung commented Jun 29, 2012

Code reviewed and functionally tested. Request Accepted.

@ayeung
Copy link
Contributor

ayeung commented Jun 29, 2012

Created a ticket deprecating iOS and Android constants and using the UI namespace instead: https://jira.appcelerator.org/browse/TIMOB-9850

ayeung pushed a commit that referenced this pull request Jun 29, 2012
Timob 9517: Added auto link support for TextField and TextArea.
@ayeung ayeung merged commit 57416b9 into tidev:master Jun 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants