New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timob 9517: Added auto link support for TextField and TextArea. #2474
Conversation
Do iOS and Mobile Web platforms support auto link in TextField and TextArea? We need to make sure that this feature is available on all platforms before merging this PR. |
iOS supports TextArea but not TextField, and I don't think MobileWeb has support for autoLink at all. |
We cannot review and merge this PR until there is a parity across all platforms. Please refer to my email yesterday about sending these changes to the architecture council mailing list. |
Mobile Web doesn't support this behavior today. It will be non-trivial for us to support this behavior too because input fields do not support embedding tags in them (i.e. you can't embed a link inside an input field). EDIT: I should clarify that it is not impossible to do, but we would have to roll our own rich text editor or use a pre-existing one. This would require a complete rewrite of textfield and textarea. |
I've brought this up in the architecture meeting today, and given the current state of the platforms, I think it's a good idea to process this PR and document the changes. It is not trivial for Mobile Web to implement this feature and iOS doesn't support autolink for TextField. Documentation of the changes should be in this PR also. |
iOS does not natively support autolink in TextField or label. iOS already has TextArea autolink support, albeit with different constants. The architectural meeting did touch on this, because there's two issues. The first is to use prevailing Android precedent and have the TextArea match the behavior they have with label. The second, because it's a behavior change, is to deprecate the constants in iOS and Android namespaces, and use new constant names in the UI namespace. Part of this change is to allow the autolink property to accept an array of constants as well. But this behavior change is for 2.2, not a parity bugfix. |
Lets process this PR and file a ticket for the behavior change as Blain outlined. |
Code reviewed and functionally tested. Request Accepted. |
Created a ticket deprecating iOS and Android constants and using the UI namespace instead: https://jira.appcelerator.org/browse/TIMOB-9850 |
Timob 9517: Added auto link support for TextField and TextArea.
Testing steps in JIRA: https://jira.appcelerator.org/browse/TIMOB-9517