[TIMOB-9580] Android: Images captured using Ti.Media.showCamera() are written to SD card on Android #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 25, 2012 13:04
We don't need to write the image data to the FS if using our customer overlay activity IF the user does not want it saved to the photo gallery.
| break; | ||
| } | ||
| } catch (NullPointerException e) { | ||
| //Ignore |
There was a problem hiding this comment.
Why are we ignoring a NullPointer? If something is going to throw a null pointer exception, we shouldn't even try to call it imo.
There was a problem hiding this comment.
This is just some old code I moved. Yeah I agree it's pretty bad, but it's a hack to detect the HTC camera application.
|
Code reviewed. Please address comments. |
|
Code reviewed and functionally tested on Samsung Galaxy 10.1 (3.1), HTC Sensation (2.3), and Galaxy Nexus (4.0.2). Kindle Fire and Nook don't have camera but code is updated in camera classes to sync with new behavior changes. Request accepted |
hieupham007
added a commit
that referenced
this pull request
Jun 29, 2012
[TIMOB-9580] Android: Images captured using Ti.Media.showCamera() are written to SD card on Android
|
Hey any one can tell me how to use these modules in titanium? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bugs with the camera saving images to the SD card. It is not always necessary to
write the image data to the SD card (presents security concerns for some apps) and when we do
create a temporary file, we never clean them up.
See the JIRA ticket for further details about testing. It is important we test on a wide range of
devices for multiple vendors (ex: HTC, Samsung, LG). Please also run all Camera examples in KS,
this PR enables more examples that where previously iOS only.