Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIMOB-9416: Android: Can't create a custom url for the app #2492

Merged
merged 2 commits into from Jul 3, 2012

Conversation

ayeung
Copy link
Contributor

@ayeung ayeung commented Jun 29, 2012

https://jira.appcelerator.org/browse/TIMOB-9416

Test case in Jira. Please also run 'android' test suite on drillbit (emulator and one other device) with both runtimes. This also touches code regarding the postlayout event and heavy weight window. Please try the following code to verify:

var winMain = Ti.UI.createWindow({
    backgroundColor : 'white',
    fullscreen : false,
    navBarHidden : true
});


var logoutButton = Ti.UI.createButton({
    title : 'Logout',
    backgroundColor:'orange',
    width : 60,
    height : 40
});
winMain.add(logoutButton);

winMain.addEventListener('postlayout', function(){
    Ti.API.info('-----------------------------post layout');
});

winMain.open();

When running the app, you should see the post layout message in the logs.

Allen Yeung added 2 commits June 29, 2012 15:10
…t proxy in windowCreated().

Also allow layout to continue when there is no root activity, and current activity is a JS activity.
@joshthecoder
Copy link
Contributor

Code reviewed and functional testing.

Ran drillbit tests (android, ui, android.ui) all still passing.
Ran test case in JIRA ticket, was able to launch application from browser just fine.

Accepted

@mstepanov
Copy link
Contributor

FT FAILED on GalaxyTab following the provided instructions.

@ayeung
Copy link
Contributor Author

ayeung commented Jul 2, 2012

Updated the test case. Typing the url in the browser does not consistently work. The browser may have some special behavior when resolving the url. I get the same behavior in a native android app, so it's not a platform bug. We can consistently get the browser to recognize custom urls if we have the url inside a webpage, so I have updated the test case to use a webpage with our custom url in it.

@pingwang2011
Copy link
Contributor

Ran the updated test case in the comment of JIRA. Passed on HTC Sensation 4G (2.3.4). Failed on Galaxy Tab (3.2) and ASUS Transformer (3.1).

mstepanov pushed a commit that referenced this pull request Jul 3, 2012
TIMOB-9416: Android: Can't create a custom url for the app
@mstepanov mstepanov merged commit d5f10ea into tidev:master Jul 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants