Timob 9361 - Android/iOS parity re webview error event message and errorCode.

[billdawson]

See JIRA.

Needs iOS and Android revieweres. Not supported in MobileWeb.

[sptramer]

Should be NSURLErrorCancelled constant instead of magic number.

[sptramer]

Code reviewed (iOS). Please address comments.

[billdawson]

Ready for re-review @sptramer

[sptramer]

Code reviewed for iOS, APPROVED

[rusticphilosopher]

Functional test passed but docgen throws the following error:

[INFO] Parsing YAML files
[ERROR] Exception occured while processing /Users/ocyrus/dev/appcelerator/git/titanium_mobile/apidoc/Titanium/UI/Window.yml:
[ERROR] Traceback (most recent call last):
[ERROR] File "./docgen.py", line 138, in load_one_yaml
[ERROR] types = [the_type for the_type in yaml.load_all(f)]
[ERROR] File "/Library/Python/2.7/site-packages/PyYAML-3.10-py2.7-macosx-10.7-intel.egg/yaml/init.py", line 83, in load_all
[ERROR] yield loader.get_data()
[ERROR] File "/Library/Python/2.7/site-packages/PyYAML-3.10-py2.7-macosx-10.7-intel.egg/yaml/constructor.py", line 33, in get_data
[ERROR] return self.construct_document(self.get_node())
[ERROR] File "/Library/Python/2.7/site-packages/PyYAML-3.10-py2.7-macosx-10.7-intel.egg/yaml/composer.py", line 27, in get_node
[ERROR] return self.compose_document()
[ERROR] File "/Library/Python/2.7/site-packages/PyYAML-3.10-py2.7-macosx-10.7-intel.egg/yaml/composer.py", line 55, in compose_document
[ERROR] node = self.compose_node(None, None)
[ERROR] File "/Library/Python/2.7/site-packages/PyYAML-3.10-py2.7-macosx-10.7-intel.egg/yaml/composer.py", line 84, in compose_node
[ERROR] node = self.compose_mapping_node(anchor)
[ERROR] File "/Library/Python/2.7/site-packages/PyYAML-3.10-py2.7-macosx-10.7-intel.egg/yaml/composer.py", line 133, in compose_mapping_node
[ERROR] item_value = self.compose_node(node, item_key)
[ERROR] File "/Library/Python/2.7/site-packages/PyYAML-3.10-py2.7-macosx-10.7-intel.egg/yaml/composer.py", line 82, in compose_node
[ERROR] node = self.compose_sequence_node(anchor)
[ERROR] File "/Library/Python/2.7/site-packages/PyYAML-3.10-py2.7-macosx-10.7-intel.egg/yaml/composer.py", line 111, in compose_sequence_node
[ERROR] node.value.append(self.compose_node(node, index))
[ERROR] File "/Library/Python/2.7/site-packages/PyYAML-3.10-py2.7-macosx-10.7-intel.egg/yaml/composer.py", line 84, in compose_node
[ERROR] node = self.compose_mapping_node(anchor)
[ERROR] File "/Library/Python/2.7/site-packages/PyYAML-3.10-py2.7-macosx-10.7-intel.egg/yaml/composer.py", line 127, in compose_mapping_node
[ERROR] while not self.check_event(MappingEndEvent):
[ERROR] File "/Library/Python/2.7/site-packages/PyYAML-3.10-py2.7-macosx-10.7-intel.egg/yaml/parser.py", line 98, in check_event
[ERROR] self.current_event = self.state()
[ERROR] File "/Library/Python/2.7/site-packages/PyYAML-3.10-py2.7-macosx-10.7-intel.egg/yaml/parser.py", line 428, in parse_block_mapping_key
[ERROR] if self.check_token(KeyToken):
[ERROR] File "/Library/Python/2.7/site-packages/PyYAML-3.10-py2.7-macosx-10.7-intel.egg/yaml/scanner.py", line 116, in check_token
[ERROR] self.fetch_more_tokens()
[ERROR] File "/Library/Python/2.7/site-packages/PyYAML-3.10-py2.7-macosx-10.7-intel.egg/yaml/scanner.py", line 257, in fetch_more_tokens
[ERROR] % ch.encode('utf-8'), self.get_mark())
[ERROR] ScannerError: while scanning for the next token
[ERROR] found character '\t' that cannot start any token
[ERROR] in "/Users/ocyrus/dev/appcelerator/git/titanium_mobile/apidoc/Titanium/UI/Window.yml", line 366, column 1

When running validate.py, the following failure is seen (among many unrelated):
Titanium/UI/UI.yml:
x Titanium.UI
x URL_ERROR_AUTHENTICATION
x Required property for constant "permission" not found
x URL_ERROR_BAD_URL
x Required property for constant "permission" not found
x URL_ERROR_CONNECT
x Required property for constant "permission" not found
x URL_ERROR_SSL_FAILED
x Required property for constant "permission" not found
x URL_ERROR_FILE
x Required property for constant "permission" not found
x URL_ERROR_FILE_NOT_FOUND
x Required property for constant "permission" not found
x URL_ERROR_HOST_LOOKUP
x Required property for constant "permission" not found
x URL_ERROR_REDIRECT_LOOP
x Required property for constant "permission" not found
x URL_ERROR_TIMEOUT
x Required property for constant "permission" not found
x URL_ERROR_UNKNOWN
x Required property for constant "permission" not found
x URL_ERROR_UNSUPPORTED_SCHEME
x Required property for constant "permission" not found
x currentWindow
x "type" type "Titanium.UI.Window" could not be found

Rejected until validate errors are addressed.

[sptramer]

Functional tested iOS, PASSED. Also another docgen error:

[ERROR] ScannerError: while scanning for the next token
[ERROR] found character '\t' that cannot start any token
[ERROR]   in "/Volumes/Landslide/src/appcelerator/titanium_mobile_origin/apidoc/Titanium/UI/Window.yml", line 366, column 1

No idea why this shows up when validating WebView. Maybe a doc link?

[billdawson]

We recently introduced the notion of inherited documentation fields, which means the whole tree has to be evaluated by validate.py now, thus pretty much eliminating the advantage of using -f.

Changes made, ready for re-review.

[sptramer]

No code/platform functional changes; not re-tested.

Validated docs, passed. APPROVED

[rusticphilosopher]

Code reviewed and functional test passed on doc changes. Accepted