TIMOB-9878 Update to latest version of FB's API for continued functional...

[WhichKatieDid]

...ity. Tests should include Kitchen Sink, #3240 #8127 #3169 and #3211, and possibly what happens when the user changes their password on another computer at the same time.

[sptramer]

See comment on jira regarding forward-compatibility. Note that this will not prevent review/acceptance of this PR.

[sptramer]

Code reviewed. Looks OK. APPROVED.

[sptramer]

Functional test (project build). Failed:

/Volumes/Landslide/src/appcelerator/titanium_mobile_origin/iphone/iphone/../Classes/FBConnect/Facebook.m:108:32: error: use of undeclared identifier 'TiUtils'
                appSupportsBackgrounding = ![TiUtils boolValue:@"UIApplicationExitsOnSuspend" properties:[[NSBundle mainBundle] infoDictionary] def:NO];
                                             ^
1 error generated.

/Volumes/Landslide/src/appcelerator/titanium_mobile_origin/iphone/iphone/../Classes/FBConnect/FBLoginDialog.m:95:40: error: use of undeclared identifier 'kRedirectURL'
                        [[url absoluteString] rangeOfString:kRedirectURL].location != NSNotFound) {
                                                            ^
1 error generated.

Indicates that some of our custom code may have been dropped or inappropriately diffed.

[WhichKatieDid]

Ready for review again.

[sptramer]

Code reviewed, APPROVED.

[sptramer]

OK, seeing an inconsistency during testing that I can't confirm is a regression or not since we can't even log in with the older SDK - when I log out and then log back in, there is no additional prompt for a login. There are some other issues (probably related to the facebook SDK): Sometimes the login dialog does not appear (remains activity indicator) - but this is very intermittent.

The login/logout issue seems like a problem though. Can anyone confirm if this is a regression?

EDIT: This was a bizarre circumstance created by having an old set of user defaults for Kitchen Sink sitting around, apparently.

[WhichKatieDid]

I've been noticing that FB has been sluggish in some spots, but a lot of that is their own SDK. Do you think we could compare against the facebook app?

[sptramer]

Continued testing, iPhone Sim 5.1:

KS -> Facebook: Pass
9878: Pass (note: when you log out in this app, the login is not persistent; strange, but means that is likely not a regression)
8127: Pass
3211: Pass
3169: Part of KS (pass)
3240: Pass

APPROVED