timob-9846: Android: Views like Label and Label on Button remain on the screen even after window is closed #2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code reviewed and functional tested. Accepted |
joshthecoder
added a commit
that referenced
this pull request
Jul 13, 2012
timob-9846: Android: Views like Label and Label on Button remain on the screen even after window is closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-9846
Don't release views in ActivityWindowProxy.handleClose() because at this point the window activity is still in finishing (not finished yet). Since window.closeFromActivity() is called in TiBaseActivity.onDestroy() which releases all the views, just removed releaseViews() from ActivityWindowProxy.handleClose().
Test case in JIRA.