Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timob 9135: Added supported for tabsBackgroundColor for iOS5+ #2538

Merged
merged 4 commits into from Jul 12, 2012

Conversation

hieupham007
Copy link
Contributor

@@ -192,7 +192,8 @@ properties:

A tab's [backgroundColor](Titanium.UI.Tab.backgroundColor) property takes precedence if set.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs need to state that this is supported on IOS version 5.0 or greater

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Mobile web the color precedence is tab.backgroundColor, tabGrp.activeTabBackgroundColor, tabGrp.tabsBackgroundColor.
On IOS the backgroundColor applies to all states and all tabs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked with Bryan. The existing description looks good. Will make some modifications regarding iOS.

description: |
For information about color values, see the "Colors" section of <Titanium.UI>.

A tab's [backgroundColor](Titanium.UI.Tab.backgroundColor) property takes precedence if set.

On iOS, [backgroundColor](Titanium.UI.Tab.backgroundColor) property applies to all states and all tabs, not just inactive tabs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok my mistake. I meant tabsBackgroundColor property applies to all tabs/all states

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of right now the tab.backgroundColor does not work on IOS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok fixed.

@vishalduggal
Copy link
Contributor

Code Reviewed. ACCEPTED

@vishalduggal
Copy link
Contributor

validate and docgen passed. Functional passed. ACCEPTED

vishalduggal added a commit that referenced this pull request Jul 12, 2012
Timob 9135: Added supported for tabsBackgroundColor for iOS5+
@vishalduggal vishalduggal merged commit 06fb8c9 into tidev:master Jul 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants