New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timob 9135: Added supported for tabsBackgroundColor for iOS5+ #2538
Conversation
@@ -192,7 +192,8 @@ properties: | |||
|
|||
A tab's [backgroundColor](Titanium.UI.Tab.backgroundColor) property takes precedence if set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs need to state that this is supported on IOS version 5.0 or greater
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Mobile web the color precedence is tab.backgroundColor, tabGrp.activeTabBackgroundColor, tabGrp.tabsBackgroundColor.
On IOS the backgroundColor applies to all states and all tabs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked with Bryan. The existing description looks good. Will make some modifications regarding iOS.
description: | | ||
For information about color values, see the "Colors" section of <Titanium.UI>. | ||
|
||
A tab's [backgroundColor](Titanium.UI.Tab.backgroundColor) property takes precedence if set. | ||
|
||
On iOS, [backgroundColor](Titanium.UI.Tab.backgroundColor) property applies to all states and all tabs, not just inactive tabs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok my mistake. I meant tabsBackgroundColor property applies to all tabs/all states
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of right now the tab.backgroundColor does not work on IOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok fixed.
Code Reviewed. ACCEPTED |
validate and docgen passed. Functional passed. ACCEPTED |
Timob 9135: Added supported for tabsBackgroundColor for iOS5+
Testing steps in JIRA: https://jira.appcelerator.org/browse/TIMOB-9135