TIMOB-5824: Android: WebView.evalJS Causes Form Input Fields to Lost/Not Retain Focus #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 10, 2012 23:41
| String code = "javascript:_TiReturn.setValue((function(){try{return " + expression | ||
| + "+\"\";}catch(ti_eval_err){return '';}})());"; | ||
| Log.d(LCAT, "getJSValue:" + code); | ||
| synchronized (this) { |
There was a problem hiding this comment.
Synchronizing on codeSnippets is safer.
|
Code updated, ready for review again. |
|
CR/FR in progress |
| Log.e(LCAT, "Interrupted", e); | ||
| // Don't try to evaluate js code again if the binding has already been destroyed | ||
| if (!destroyed) { | ||
| String code = "javascript:_TiReturn.setValue((function(){try{return " + expression |
There was a problem hiding this comment.
Given that now you do direct eval(code), seems like you don't need 'javascript:' prefix ?
|
Code reviewed. Will accept CR and perform FR once comments Max made regarding the javascript prefix have been addressed. |
| } | ||
|
|
||
| if (destroyed) { | ||
| return null; |
|
Code updated. |
|
Code looks good. APPROVED |
|
Code reviewed and functional test passed. KS tested and looks ok on both V8 and Rhino. Accepted |
rusticphilosopher
pushed a commit
that referenced
this pull request
Jul 13, 2012
TIMOB-5824: Android: WebView.evalJS Causes Form Input Fields to Lost/Not Retain Focus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-5824
To test, please use test case in Jira.
Please run in KS: Base UI > Views > Web Views > Local URL.
Also, run ui test suite in drillbit.