[TIMOB-9560] iOS: implement function call()/apply() #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code reviewed. APPROVED. Will wait for second CR before functional. |
|
Something doesn't seem right. There has to be a more elegant way to do this. |
|
I agree, but it works and making it more appropriate may require extensive modifications to the kroll system, which we have explicitly been told to not do. |
|
Ah. In that case, CR approved. |
|
It is requires KrollMethod redesign/drop indeed. A function should not be an object with custom class. |
|
Functional tested, iPhone Sim 5.1. Passed. APPROVED. |
sptramer
pushed a commit
that referenced
this pull request
Jul 12, 2012
[TIMOB-9560] iOS: implement function call()/apply()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIMOB-9560
Complete test case in JIRA comments.