Timob 9827 Android: Translate animations of invisible views may be delayed #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ff-screen) should invalidate parent to avoid Android delaying the animation start time.
| @@ -290,26 +293,48 @@ public AnimationSet render(TiViewProxy viewProxy, View view, int x, int y, int w | |||
| TiDimension optionTop = null, optionBottom = null; | |||
| TiDimension optionLeft = null, optionRight = null; | |||
| TiDimension optionCenterX = null, optionCenterY = null; | |||
|
|
|||
|
|
|||
| TiUIView tiView = viewProxy.peekView(); | |||
There was a problem hiding this comment.
We should probably do a null check for tiView
There was a problem hiding this comment.
Nm, ignore this comment, I thought you were calling tiView.getBottom below =)
|
Code reviewed, left one comment. |
|
Good point, lemme fix that |
|
Ready for re-review. |
|
Code reviewed and functionally tested. Request Accepted |
ayeung
pushed a commit
that referenced
this pull request
Jul 13, 2012
Timob 9827 Android: Translate animations of invisible views may be delayed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JIRA Testing Notes.
NOTE Please also resolve TIMOB-9954 with this. The test app in TIMOB-9827 includes a part called "extended tests", which will show that 9827 is fixed. You can review 9827 description to see what I mean.