Timob 9813 Android: Animation anomaly: backgrounds bleed through #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iews not currently visible on screen. Also use queue idle handler pre-honeycomb to help avoid animation artifacts.
…mation -- can significantly help reduce small background artifacts. Use that in lieue of the queue idle timer, which is too dangerous
| // Could be animating from nothing to something | ||
| invalidateParent = true; | ||
| } else { | ||
| Rect r = new Rect(0, 0, nativeView.getWidth(), nativeView.getHeight()); |
There was a problem hiding this comment.
could re-use width/height variables here
|
Code reviewed, left minor comment. |
|
Code reviewed and functionally tested. Request Accepted |
ayeung
pushed a commit
that referenced
this pull request
Jul 18, 2012
Timob 9813 Android: Animation anomaly: backgrounds bleed through
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Testing Notes.
Important to test on 2.2/2.3 (not necessarily both, IMO, but feel free), 3.x and 4.x.