[TIMOB-10010][TIMOB-10047] Modernize animation, fix autoreverse problems #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es to avoid bad behavior. Also, autoreverse now reverses ALL changes made by an animation.
…property reversion support.
| if ([animation isReverse]) { | ||
| RELEASE_TO_NIL(animation.animatedView); | ||
|
|
||
| animation = [animation reverseAnimation]; // Use the original animation for correct evenitng |
|
NOTE: There should also probably be some internal testing done with enterprise apps known to use animations extensively. This will help get an idea of if there are other important behavior changes. |
| [UIView setAnimationRepeatCount:repeatCount]; | ||
| } | ||
| else { | ||
| [UIView setAnimationRepeatCount:1.0]; |
There was a problem hiding this comment.
Could be shortened to [UIView setAnimationRepeatCount:repeatCount != 0.0 ? repeatCount : 1.0];
|
Code reviewed. APPROVED |
|
FT PASSED |
mstepanov
pushed a commit
that referenced
this pull request
Jul 25, 2012
[TIMOB-10010][TIMOB-10047] Modernize animation, fix autoreverse problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the animation subsystem to the block-based system available since iOS 4.x, and also fixes an issue with autoreverse animations where they would be rendered incorrectly upon animation completion (and ignore many properties changed during the animation). Should be fully regression tested against all available KitchenSink animation suites (Base UI->Animation).
TIMOB-10010
TIMOB-10047