TIMOB-9955: Android: ScrollView with a wrap view becomes unscrollable on... #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on android Ti 2.1
|
CR/FR accepted. Easily reproduced fail case, and noticed that scrolling does work < 2.1.0. Now it works again with this fix. Also ran in iOS and confirmed parity wrt long touch on the inner views canceling the scroll. |
billdawson
added a commit
that referenced
this pull request
Jul 25, 2012
TIMOB-9955: Android: ScrollView with a wrap view becomes unscrollable on...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... android Ti 2.1
https://jira.appcelerator.org/browse/TIMOB-9955
Test case in Jira.
Note: In the test case, it will stop scrolling if you do a long press on the inner-view. This seems to be the same behavior as iOS.