New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TC-1101] Added Ti.App.Properties 'change' event for iOS #2635
Conversation
Signed CLA is in place. |
@farfromrefug - We need a JIRA ticket and a test case to process this PR. |
Will do thanks |
JIRA ticket + test case |
Forwarded questions internally about if there'd be any issue with Android or Mobile Web implementing this, too. CR edge case: It's highly unlikely, but could you add:
in the beginning of TiAppPropertiesProxy's dealloc? There is a possibility that the proxy is removed before a listener is. Similarly, you will need to have
around any access to nsnotificationcenter, since it's not threadsafe and the _listenerAdded/removed happens in a background thread. |
yes you are right! |
About android implementation i didnt see any way to change properties outside application so i didnt see the need for such implementation |
CR approved, generated TIMOB-10260 and TIMOB-10262 for parity, in case you want to add to the pull request on other OSes. |
FR passed. Merging pull. |
[TC-1101] Added Ti.App.Properties 'change' event for iOS
I will look at it. By the way shouldnt we add documentation for this ? (that would be my first so a good thing ;)) |
I added a "change" event to Ti.App.Properties to listen for changes of Properties