[TIMOB-9841] iOS: Allow to hide Network Activity Indicator #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| - name: disableNetworkActivityIndicator | ||
| summary: | | ||
| Disables network activity indicator from displaying. |
There was a problem hiding this comment.
Prevents network activity indicator from being displayed.
| Disables network activity indicator from displaying. | ||
| description: | | ||
| Setting this property to true disables appearance of network activity indicator when a network activity is in progress. | ||
| In case network activity indicator is currently visible, it will be hidden. |
There was a problem hiding this comment.
There's two extra spaces at the beginning of this line, I think--should line up with previous line. Suggest changing it to:
If the network activity indicator is currently visible, it is hidden immediately.
|
Doc reviewed, validated & ran docgen. Accepted. |
|
Hold CR until additional commit is pushed. |
|
Reviewed doc, ran validate and docgen. Accepted. |
| **NOTE: In general, the user should always be made aware of network activity. The network activity indicator should only be disabled for very brief network activity (a few seconds).** | ||
| type: Boolean | ||
| default: false | ||
| platforms: [iphone, ipad] |
|
Code Reviewed. Missing since tag otherwise ok. |
|
Code Reviewed. ACCEPTED |
|
Functional Passed. Ran validate and docgen. ACCEPTED |
vishalduggal
added a commit
that referenced
this pull request
Jul 31, 2012
[TIMOB-9841] iOS: Allow to hide Network Activity Indicator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIMOB-9841
Test case in JIRA comments.