Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timob 10291 - Update API and Doc to lower case events. #2686

Merged
merged 4 commits into from Aug 17, 2012

Conversation

WhichKatieDid
Copy link
Contributor

To be used with iOS, Android, and Mobile Web pulls for TIMOB-10292, TIMOB-10293, TIMOB-10294. DO NOT MERGE until all three pulls have been merged.

@WhichKatieDid
Copy link
Contributor Author

Kitchen sink changes moved to appcelerator-developer-relations/KitchenSink#20

@@ -37,6 +37,8 @@ events:
Setting a listener disables the default key handling for the Back button.
To restore default behavior, remove the listener. It is recommended that you only
have one handler per heavyweight window.
deprecated:
since: "2.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we mention what is the new event's name ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh. This one slipped by the radar.

@srahim
Copy link
Contributor

srahim commented Aug 9, 2012

Minor nit pick in the last file . Rest of it seems good.

@srahim
Copy link
Contributor

srahim commented Aug 10, 2012

updateddomains event in bonjour module is missing in docs. Needs to provide new doc and possibly old doc for the event.

@WhichKatieDid
Copy link
Contributor Author

updated[D,d]omains is rather crufty. I'd want to spend some time figuring out what it does, as it might even be in the wrong area (Code is in service, Apple's docs imply browser).

@WhichKatieDid
Copy link
Contributor Author

Talked with Sabil, made new bug for updatedDomains, https://jira.appcelerator.org/browse/TIDOC-753 so that it can be fixed at another time and not block processing this pull.

@srahim
Copy link
Contributor

srahim commented Aug 16, 2012

Doc looks good.

Marking PR on hold until MW and android implementations are done with.

@srahim
Copy link
Contributor

srahim commented Aug 17, 2012

Ran validate.py and docgen.py

APPROVED

srahim added a commit that referenced this pull request Aug 17, 2012
Timob 10291 - Update API and Doc to lower case events.
@srahim srahim merged commit 0a183f8 into tidev:master Aug 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants