TIMOB-10215 If JSCA file creation contains runtime errors, fail it immed... #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mediately so that our scons build will also failed. This avoids accidentally creating releases which contain bad or partial api.jsca files.
|
Reviewed code and tested. Verified with the fix installed, the build fails if there's an error in the doc syntax, and succeeds if there are no doc errors. Without the fix installed, the build succeeds whether or not the JSCA build throws an error. Accepted. Note that master currently contains a syntax error in TextArea.yml that will break the build. I'll check in a fix for that separately. |
|
Doc fix to ensure that the build doesn't break: |
arthurevans
pushed a commit
that referenced
this pull request
Aug 9, 2012
TIMOB-10215 If JSCA file creation contains runtime errors, fail it immed...
|
#2707 is a 2_1_X cherry-pick of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...iately so that our scons build will also failed. This avoids accidentally creating releases which contain bad or partial api.jsca files.
See JIRA:
https://jira.appcelerator.org/browse/TIMOB-10215