Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timob 10052 - Add ScrollsToTop to table, text field #2690

Merged
merged 5 commits into from Aug 8, 2012

Conversation

WhichKatieDid
Copy link
Contributor

Includes changes made by @meeech in pull #2605. Test is in Jira.

@vishalduggal
Copy link
Contributor

Will CR + FR

you will need to disable (set to false) on the above views you DON'T want this
behaviour on. The remaining view will then respond to scroll-to-top gesture.
type: Boolean
default: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default is undefined but behaves as if true.

@vishalduggal
Copy link
Contributor

Code Reviewed. Some minor doc changes required otherwise looks good.

@vishalduggal
Copy link
Contributor

Code reviewed and accepted. However there are merge conflicts that need to be resolved before this PR can be processed.

Conflicts:
	iphone/Classes/TiUITextAreaProxy.m
@vishalduggal
Copy link
Contributor

Code Reviewed. ACCEPTED

@vishalduggal
Copy link
Contributor

Functional Passed. ACCEPTED

vishalduggal added a commit that referenced this pull request Aug 8, 2012
Timob 10052 - Add ScrollsToTop to table, text field
@vishalduggal vishalduggal merged commit d892ae3 into tidev:master Aug 8, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants