[TIMOB-8212] Updated textfield/area to fix a ton of bugs. #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -97,33 +92,14 @@ define(["Ti/_/declare", "Ti/_/UI/TextBox", "Ti/_/css", "Ti/_/dom", "Ti/_/lang", | |||
|
|
|||
| hintText: { | |||
| set: function(value) { | |||
| this._field.placeholder = value; | |||
| //this._field.placeholder = value; | |||
There was a problem hiding this comment.
Did you mean to comment this out? Seems we need this. Now, IE9 does not support he placeholder attribute, so perhaps we just roll our own placeholder? Or possibly shim placeholder for IE9 using a has block?
|
Couple of issues:
Regardless of issues, proceeding with PR. Code reviewed and tested. Request APPROVED. |
cb1kenobi
added a commit
that referenced
this pull request
Aug 9, 2012
[TIMOB-8212] Updated textfield/area to fix a ton of bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the following tickets:
TIMOB-8212
TIMOB-8277
TIMOB-9717
TIMOB-10089
TIMOB-10132
TIMOB-10156
TIMOB-10221