[TIMOB-9944] Do not override UIResponder chain for touchDelegate #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - (void) reloadAndRestoreSelection | ||
| { | ||
| NSIndexPath* curSelected = [[self tableView] indexPathForSelectedRow]; | ||
| [[self tableView] reloadData]; |
There was a problem hiding this comment.
Okay, this scares me. ReloadData is VERY expensive and worse yet, has in the past stomped on interface state machines and caused tables to become unresponsive. Are you sure reloadData is needed?
|
TableView will internally only redisplay rows that are visible so it should not be very expensive, however I see an issue here when table is editing or moving at which point it would cause problems. Hold off on FR |
|
Ready for review |
|
CR passed, but will be checking to see why we had that touchDelegate in the first place. |
|
FR passed. merging. |
WhichKatieDid
added a commit
that referenced
this pull request
Aug 11, 2012
[TIMOB-9944] Do not override UIResponder chain for touchDelegate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test is in JIRA
See the video mentioned in the comments to reproduce the issue.