[TIMOB-10347] Implemented support for applyProperties method. #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,3 +61,13 @@ methods: | |||
| summary: A dictionary of keys and values to add to the <Titanium.Event> object | |||
| sent to the listeners. | |||
| type: Dictionary | |||
| - name: applyProperties | |||
| summary: Applies the properties to the proxy | |||
There was a problem hiding this comment.
Indentation is tweaked--looks like you have tabs instead of spaces.
Also, please add a period at the end fo both summaries (above and the parameter summary, below).
| this[i] = props[i]; | ||
| } | ||
| }, | ||
|
|
There was a problem hiding this comment.
Or you could have just done:
applyProperties: function(props) {
require.mix(this, props);
}
There's a bit of a debate if var i should go in the for loop or not. JSLint says var i should NOT go in the for loop. However, JSLint says you should do a hasOwnProperty() check on i. mix() does the hasOwnProperty() check. I would say move the var into the for loop or use require.mix().
|
Code reviewed and tested. Request APPROVED. |
cb1kenobi
added a commit
that referenced
this pull request
Aug 10, 2012
[TIMOB-10347] Implemented support for applyProperties method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.