Timob 10309: Android: Ti.Geolocation.forwardGeocoder() callback is not called for a bad address #2700
Conversation
| String errorCode = jsonObject.getString(TiC.ERROR_PROPERTY_ERRORCODE); | ||
| errorDict.put(TiC.PROPERTY_MESSAGE, "Unable to resolve message: Code (" + errorCode + ")"); | ||
| errorDict.put(TiC.PROPERTY_CODE, errorCode); |
There was a problem hiding this comment.
Why did you delete these?
There was a problem hiding this comment.
Because on iOS, the property "error" is a string. I deleted these and put all those info to a string for parity with iOS.
|
Code reviewed. Please address comments. Also, functional tested and I notice that on iOS, only 1 alert pops up at a time, i.e if you don't close the 1st alert, you won't see the 2nd one. That's not the case in Android, i.e: alerts come up on top of one another. I know this is doable in Android but will be a bit tricky. |
|
@hieupham007, the alert issue on Android you mentioned is filed in JIRA (https://jira.appcelerator.org/browse/TIMOB-6246). |
|
Functional failed. Got this error twice in log http://pastie.org/private/ygqgdgbppqvet6b8vhl6a. The error should be handled gracefully. |
|
That error is caused by the invalid address. It is caught and output in the log. And in callback we return the event with success=false. |
|
Hmm, if its caught we shouldn't print out the stack traces though. A Log.e would suffice. |
|
Ready for review again. |
|
Code reviewed and functionally tested. Request Accepted |
Timob 10309: Android: Ti.Geolocation.forwardGeocoder() callback is not called for a bad address
https://jira.appcelerator.org/browse/TIMOB-10309
Test steps in JIRA.