TIMOB-9823 Apidocs: make sure that a derived "since" version value is not earlier... #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ier than a parent's since value. Example: it wouldn't make sense for a method to be since 0.9 if the type itself is only since 2.1.0.
|
Will CR/FR. |
| for parent_entry in parent.platforms: | ||
| if parent_entry["name"] == platform_name: | ||
| parent_version_parts = parent_entry["since"].split(".") | ||
| if parent_version_parts > version_parts: |
There was a problem hiding this comment.
I didn't know you could do this in python. That is just insanely handy.
|
CR/FR passed, Accepted. |
arthurevans
pushed a commit
that referenced
this pull request
Aug 9, 2012
TIMOB-9823 Apidocs: make sure that a derived "since" version value is not earlier...
|
It's funny, every time I use that comparison-of-lists-with-string-numbers-in-them, I don't believe it myself either. :) I end up dropping in to the python shell and trying edge cases to see if it really does work. |
This was referenced Aug 10, 2012
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... than a parent's since value.
Example: it wouldn't make sense for a method to be since 0.9 if the type itself is only since 2.1.0.
See JIRA