Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timob 9799: Apidoc: New "repeatable" key for method parameter documentation (vararg) #2719

Merged
merged 3 commits into from Aug 14, 2012
Merged

Conversation

billdawson
Copy link
Contributor

See JIRA for testing notes.

@@ -56,6 +62,9 @@
% if item.optional is not None:
<span class="optional">Optional.</span>
% endif
% if item.repeatable:
<span class="optional">Repeatable.</span>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think we really needed a new class for "repeatable", since whatever the styling on "optional" is/was, I imagine it's just fine for "repeatable". And I guess with jsduck in use now, it doesn't really matter??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm with you.

@arthurevans
Copy link
Contributor

CR and FR passed. Accepted.

arthurevans pushed a commit that referenced this pull request Aug 14, 2012
Timob 9799: Apidoc: New "repeatable" key for method parameter documentation (vararg)
@arthurevans arthurevans merged commit 0e4bacd into tidev:master Aug 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants