TIMOB-7499 update to Image behavior to use a bitmap config that allows f... #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for alpha information
| @@ -637,7 +637,7 @@ public static KrollDict viewToImage(KrollDict proxyDict, View view) | |||
| Log.e(TAG, "Height property is 0 for view, display view before calling toImage()", Log.DEBUG_MODE); | |||
| } | |||
|
|
|||
| Bitmap bitmap = Bitmap.createBitmap(width, height, Config.RGB_565); | |||
| Bitmap bitmap = Bitmap.createBitmap(width, height, Config.ARGB_8888); | |||
There was a problem hiding this comment.
This fix will require 2x more memory for the same image. Seems to be a very expensive solution, which will cause memory issues when users attempt to load up high res images. Is this the only solution?
|
Code reviewed. Please address comments. |
|
Code reviewed and functionally tested. Also discussed solution with Opie. Request accepted. |
hieupham007
added a commit
that referenced
this pull request
Aug 21, 2012
TIMOB-7499 update to Image behavior to use a bitmap config that allows f...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...or alpha information
Test included in ticket.
https://jira.appcelerator.org/browse/TIMOB-7499